Conversation
|
I noticed the reasoning for non-typed values on the If this pull gets merged, would you accept a pull that types the dictionaries? |
|
Thanks for the idea - and you are quite right: we should have considered doing this. |
JorjMcKie
left a comment
There was a problem hiding this comment.
please extend this idea to the remaining "geometry" class Matrix.
Gladly! Note, this might be kind of limited in it's effectiveness because of some upstream code, namely the swig generated code. Seems easy enough to add. |
|
I think the test failures can be fixed by deleting [Presumably this was somehow forcing the creation of a |
|
Apologies, I've been trying to get a job, and I'm helping someone move. I also just found out how to run your tests locally via |
You have to be careful with that, as you don't want someone to change the identity matrix to be anything else. |
|
I haven't tested it but the only reason for the existence of |
|
I think best is to give up supplying |
|
This passes tests for me:
|
Hello, all this does is add a
__slots__entry to a few classes. this small change makes an outsized impact, reducing the size of instances dramatically, and leads the way to efficient and fully typed page extraction.